Repository navigation
Binder: pin virtual threads in withGIL; crossinline block (#161 option B) - #337
Merged
Merged
Conversation
…using it (#161 option B) withGIL's and withPython's blocks become crossinline (a public API change, user-approved) so the outermost scope on a virtual thread can run inside a native frame: C's bsearch over one element calls its comparator, an FFM upcall that runs the scope, so the virtual thread cannot unmount between PyGILState_Ensure and Release. The result or exception is carried out of the upcall. Platform threads, Android, native and wasm run the block directly. Panama gains the (long, long) -> int upcall shape; its reachability descriptor is generated from the @UpcallShape marker.
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #161 (option B, user decision; replaces option A's refusal from #303).